Bug 219417 - [GPU Process] Disconnect NativeImages from RemoteResourceCacheProxy when RemoteRenderingBackendProxy is destroyed
Summary: [GPU Process] Disconnect NativeImages from RemoteResourceCacheProxy when Remo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-01 18:05 PST by Said Abou-Hallawa
Modified: 2020-12-03 16:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2020-12-01 18:29 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (6.18 KB, patch)
2020-12-03 14:02 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-12-01 18:05:01 PST 
This is a timing issue which may cause crash if deleting RemoteRenderingBackendProxy happens before deleting the NativeImages maintained by its RemoteResourceCacheProxy.
Comment 1 Said Abou-Hallawa 2020-12-01 18:29:54 PST 
Created attachment 415184 [details]
Patch
Comment 2 Tim Horton 2020-12-01 23:54:56 PST 
Comment on attachment 415184 [details]
Patch

I guess my next question is ... can't a NativeImage be used between RemoteResourceCacheProxy instances?? (if you have two pages in one Web Content process). Or is NativeImage somehow scoped in such a way that that is not possible?
Comment 3 Said Abou-Hallawa 2020-12-03 14:02:55 PST 
Created attachment 415342 [details]
Patch
Comment 4 EWS 2020-12-03 16:24:53 PST 
Committed r270417: <https://trac.webkit.org/changeset/270417>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415342 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-03 16:25:17 PST 
<rdar://problem/71957568>