Bug 219372 – [iOS] <button> with multi-line content does not render properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

The contents are clipped to a single line, unless -webkit-appearance: none is specified.

[Aditya Keerthi]

<rdar://problem/6061602>

[Aditya Keerthi]

Created attachment 415065 [details]
Patch

[Darin Adler]

Comment on attachment 415065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415065&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1031
> +        style.setMinHeight(Length(static_cast<int>(ControlBaseHeight / ControlBaseFontSize * style.fontDescription().computedSize()), Fixed));

Is it good to still be doing a floor operation here (static_cast<int>) rather than a rounding or a ceiling operation?

[Aditya Keerthi]

(In reply to Darin Adler from comment #3)
> Comment on attachment 415065 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415065&action=review
> 
> > Source/WebCore/rendering/RenderThemeIOS.mm:1031
> > +        style.setMinHeight(Length(static_cast<int>(ControlBaseHeight / ControlBaseFontSize * style.fontDescription().computedSize()), Fixed));
> 
> Is it good to still be doing a floor operation here (static_cast<int>)
> rather than a rounding or a ceiling operation?

I think we can just remove the rounding entirely, for a more precise min-height. Uploading a new patch which does this.

I will also revisit the height calculation in the near future, as it may change due to the iOS form control redesign.

[Aditya Keerthi]

Created attachment 415071 [details]
Patch

[Aditya Keerthi]

Created attachment 415140 [details]
Patch

[Aditya Keerthi]

Rebaselined existing tests to account for the change.

[EWS]

Committed r270325: <https://trac.webkit.org/changeset/270325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415140 [details].