RESOLVED FIXED 219361
Allow blob URLs with fragments 
https://bugs.webkit.org/show_bug.cgi?id=219361
Summary Allow blob URLs with fragments
Alex Christensen
Reported 2020-11-30 11:03:38 PST
Allow blob URLs with fragments
Attachments
Patch (5.84 KB, patch)
2020-11-30 11:05 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (7.60 KB, patch)
2020-11-30 12:31 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-11-30 11:05:54 PST
Created attachment 415035 [details] Patch
Alex Christensen
Comment 2 2020-11-30 12:31:03 PST
Created attachment 415042 [details] Patch
EWS
Comment 3 2020-11-30 15:15:33 PST
Committed r270269: <https://trac.webkit.org/changeset/270269> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415042 [details].
Radar WebKit Bug Importer
Comment 4 2020-11-30 15:16:25 PST
<rdar://problem/71825595>
Darin Adler
Comment 5 2020-11-30 15:17:21 PST
Comment on attachment 415042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415042&action=review > Source/WebCore/platform/network/BlobRegistryImpl.cpp:228 > + if (url.hasFragmentIdentifier()) > + return m_blobs.get(url.stringWithoutFragmentIdentifier().toStringWithoutCopying()); > return m_blobs.get(url.string()); We should consider adding a version of toStringWithoutCopying that takes a WTF::String that is used if it happens to exactly match. Then we would not need an if statement, and could retain the "no string allocation/deallocation" optimization.
Note You need to log in before you can comment on or make changes to this bug.