Bug 219358 - [LFC] Move PositioningContext into its own file
Summary: [LFC] Move PositioningContext into its own file
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-30 08:40 PST by Don Olmstead
Modified: 2020-11-30 10:45 PST (History)
3 users (show)

See Also:

Attachments
WIP Patch (10.42 KB, patch)
2020-11-30 08:41 PST, Don Olmstead 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-11-30 08:40:02 PST 
https://trac.webkit.org/changeset/270224/webkit broke the non-unified build because the BuildingState struct was defined in a cpp file. It references PositioningContext which is a class defined in that same file. Move it out into its own set of files.
Comment 1 Don Olmstead 2020-11-30 08:41:43 PST 
Created attachment 415027 [details]
WIP Patch
Comment 2 Simon Fraser (smfr) 2020-11-30 10:40:26 PST 
Comment on attachment 415027 [details]
WIP Patch

Just need a TreeBuilder::~TreeBuilder() = default in the cpp file.
Comment 3 Simon Fraser (smfr) 2020-11-30 10:45:33 PST 
Fixed more simply in r270251.