RESOLVED WONTFIX 219358
[LFC] Move PositioningContext into its own file 
https://bugs.webkit.org/show_bug.cgi?id=219358
Summary [LFC] Move PositioningContext into its own file
Don Olmstead
Reported 2020-11-30 08:40:02 PST
https://trac.webkit.org/changeset/270224/webkit broke the non-unified build because the BuildingState struct was defined in a cpp file. It references PositioningContext which is a class defined in that same file. Move it out into its own set of files.
Attachments
WIP Patch (10.42 KB, patch)
2020-11-30 08:41 PST, Don Olmstead 		simon.fraser: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-11-30 08:41:43 PST
Created attachment 415027 [details] WIP Patch
Simon Fraser (smfr)
Comment 2 2020-11-30 10:40:26 PST
Comment on attachment 415027 [details] WIP Patch Just need a TreeBuilder::~TreeBuilder() = default in the cpp file.
Simon Fraser (smfr)
Comment 3 2020-11-30 10:45:33 PST
Fixed more simply in r270251.
Note You need to log in before you can comment on or make changes to this bug.