Bug 219330 - [LFC][IFC] Remove LineBuilder::availableWidth
Summary: [LFC][IFC] Remove LineBuilder::availableWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-28 17:04 PST by zalan
Modified: 2020-11-29 11:11 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.02 KB, patch)
2020-11-28 17:10 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (6.06 KB, patch)
2020-11-28 19:49 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-11-28 17:04:48 PST
there is no "global" available width. it should be recomputed whenever we add a new inline level box to accommodate for intrusive floats.
Comment 1 zalan 2020-11-28 17:10:27 PST
Created attachment 414982 [details]
Patch
Comment 2 Sam Weinig 2020-11-28 17:13:33 PST
Comment on attachment 414982 [details]
Patch

Is this observable? Can this be tested / is this tested already?
Comment 3 zalan 2020-11-28 19:49:01 PST
Created attachment 414984 [details]
Patch
Comment 4 zalan 2020-11-29 10:43:40 PST
(In reply to Sam Weinig from comment #2)
> Comment on attachment 414982 [details]
> Patch
> 
> Is this observable? Can this be tested / is this tested already?
Not yet, this is in preparation for supporting cases when the inline level box stretches the line vertically and we need to check if floats are in the way (so the line may have different available space values depending on the current line height).
Comment 5 EWS 2020-11-29 11:10:23 PST
Committed r270228: <https://trac.webkit.org/changeset/270228>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414984 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-29 11:11:20 PST
<rdar://problem/71787245>