Bug 21932 - Add non-pointer symbol lookups to SoftLinking.h
Summary: Add non-pointer symbol lookups to SoftLinking.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-28 13:47 PDT by Greg Bolsinga
Modified: 2008-10-28 14:43 PDT (History)
1 user (show)

See Also:

Attachments
looks up non pointer symbols (1.38 KB, patch)
2008-10-28 13:49 PDT, Greg Bolsinga 		darin: review+
Details | Formatted Diff | Diff
changed SYMBOL to DATA (1.37 KB, patch)
2008-10-28 14:33 PDT, Greg Bolsinga 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2008-10-28 13:47:47 PDT 
It can currently look up pointers, but not symbols that aren't pointers.
Comment 1 Greg Bolsinga 2008-10-28 13:49:35 PDT 
Created attachment 24728 [details]
looks up non pointer symbols

This is needed for some other platform work.
Comment 2 Darin Adler 2008-10-28 13:54:28 PDT 
Comment on attachment 24728 [details]
looks up non pointer symbols

The change seems fine. But I'm not sure "SYMBOL" is a good name for this. They're all symbols. Maybe "OBJECT"?

r=me as-is, but please consider other names
Comment 3 Greg Bolsinga 2008-10-28 14:28:31 PDT 
How about DATA, as I'm using this to get data constants?
Comment 4 Greg Bolsinga 2008-10-28 14:33:11 PDT 
Created attachment 24730 [details]
changed SYMBOL to DATA

Same as before, but SYMBOL is not DATA
Comment 5 David Kilzer (:ddkilzer) 2008-10-28 14:37:22 PDT 
(In reply to comment #3)
> How about DATA, as I'm using this to get data constants?

CONSTANT might work better.
Comment 6 David Kilzer (:ddkilzer) 2008-10-28 14:43:23 PDT 
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/mac/SoftLinking.h
Committed r37941

Changed SYMBOL/DATA to CONSTANT when landing.

http://trac.webkit.org/changeset/37941