Bug 219310 - [LFC Display] Fix box locations for positioned elements
Summary: [LFC Display] Fix box locations for positioned elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-27 10:20 PST by Simon Fraser (smfr)
Modified: 2020-11-27 18:33 PST (History)
5 users (show)

See Also:


Attachments
Patch (26.44 KB, patch)
2020-11-27 10:20 PST, Simon Fraser (smfr)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (26.42 KB, patch)
2020-11-27 11:28 PST, Simon Fraser (smfr)
zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-11-27 10:20:22 PST
[LFC Display] Fix box locations for positioned elements
Comment 1 Simon Fraser (smfr) 2020-11-27 10:20:36 PST
Created attachment 414953 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-11-27 11:28:29 PST
Created attachment 414960 [details]
Patch
Comment 3 zalan 2020-11-27 14:26:37 PST
Comment on attachment 414960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414960&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:233
> +    return isInitialContainingBlock() || isPositioned() || style().hasTransform();

I'd change it to return isPositioned() || isContainingBlockForFixedPosition(); -which makes it quite clear that fixed positioning is a type of out-of-flow.
Comment 4 Simon Fraser (smfr) 2020-11-27 18:32:26 PST
https://trac.webkit.org/changeset/270209/webkit
Comment 5 Radar WebKit Bug Importer 2020-11-27 18:33:15 PST
<rdar://problem/71769575>