Bug 219308 - [GTK][WPE] Async scrolling udpates are blocked in the main thread
Summary: [GTK][WPE] Async scrolling udpates are blocked in the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-27 08:42 PST by Alejandro G. Castro
Modified: 2020-12-01 02:26 PST (History)
23 users (show)

See Also:

Attachments
Patch (6.58 KB, patch)
2020-11-27 09:19 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Patch for landing (4.18 MB, patch)
2020-12-01 01:17 PST, Alejandro G. Castro 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (6.65 KB, patch)
2020-12-01 01:53 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2020-11-27 08:42:39 PST 
After some changes in the scrolling code WPE and GTK are not handling the scrolling thread independently when the frameDone happens, they rely on the main thread, that causes freezing in the UI.
Comment 1 Alejandro G. Castro 2020-11-27 09:19:42 PST 
Created attachment 414950 [details]
Patch
Comment 2 Alejandro G. Castro 2020-11-27 09:28:19 PST 
Regarding the problem of avoiding hasProcessedWheelEventsRecently, probably Simon can help us to clarify how Apple ports are implementing the kinetic scrolling. WPE and GTK animation based on the class ScrollAnimationKinetic that inherits from ScrollAnimation. We would like to change this and make it as similar to the Apple ports as possible to make sure it is harder we break each other ports.

The ScrollAnimationKinetic is moving the position using scrollTo directly using a timer, I guess that is not how your ports is doing it?

Thanks for the clarifications in advance.
Comment 3 Alejandro G. Castro 2020-12-01 01:17:44 PST 
Created attachment 415111 [details]
Patch for landing
Comment 4 Alejandro G. Castro 2020-12-01 01:53:42 PST 
Created attachment 415113 [details]
Patch for landing
Comment 5 EWS 2020-12-01 01:59:09 PST 
Patch 415111 does not build
Comment 6 EWS 2020-12-01 02:26:46 PST 
Committed r270292: <https://trac.webkit.org/changeset/270292>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415113 [details].