Bug 219299 – [ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Windows without Cygwin

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Fujii Hironori]

[ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Cygwin-free Windows

[Fujii Hironori]

Created attachment 414913 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

Comment on attachment 414913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review

Looks fine with one piece of feedback on the copyright. r+

> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3
> +# Copyright (C) 2020 Sony Interactive Entertainment Inc.

I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)?

[Fujii Hironori]

Comment on attachment 414913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review

Thank you for the review.

>> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3
>> +# Copyright (C) 2020 Sony Interactive Entertainment Inc.
> 
> I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)?

Ok, I'll remove it.

[Fujii Hironori]

Created attachment 414972 [details]
Patch for landing

[EWS]

Committed r270212: <https://trac.webkit.org/changeset/270212>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414972 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71770193>