Bug 219270 – Reflect.preventExtensions should not throw if called on WindowProxy or Location

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Shvayka]

Reflect.preventExtensions should not throw if called on WindowProxy or Location

[Alexey Shvayka]

Created attachment 414822 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Radar WebKit Bug Importer]

<rdar://problem/71836357>

[Yusuke Suzuki]

Comment on attachment 414822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414822&action=review

Can you check test failures?

> LayoutTests/imported/w3c/ChangeLog:13
> +        * web-platform-tests/html/browsers/history/the-location-interface/location-prevent-extensions-expected.txt: Added.
> +        * web-platform-tests/html/browsers/history/the-location-interface/location-prevent-extensions.html: Added.
> +        * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
> +        * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
> +        * web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prevent-extensions-expected.txt: Added.
> +        * web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prevent-extensions.html: Added.

Are they imported tests from WPT via import-w3c-tests? If it is not, can you put them under http/wpt/? LayoutTests/imported is only for imported tests.

[Alexey Shvayka]

(In reply to Yusuke Suzuki from comment #4)
> Can you check test failures?

Failures are caused by error message change; will adjust soon.

> Are they imported tests from WPT via import-w3c-tests? If it is not, can you
> put them under http/wpt/? LayoutTests/imported is only for imported tests.

These tests are new (not imported). I am putting them to LayoutTests/imported to leverage the WPT export process (https://trac.webkit.org/wiki/WPTExportProcess): once the patch is reviewed, I can land a WPT PR with those tests w/o additional review on GitHub (which saves a lot of time and lets us share the tests that Blink currently fails), and only then I would land the patch itself.

[Alexey Shvayka]

Created attachment 415444 [details]
Patch

Adjust expectations for error message change.

[EWS]

Committed r270702: <https://trac.webkit.org/changeset/270702>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415444 [details].