Bug 219266 - Support KHR_parallel_shader_compile
Summary: Support KHR_parallel_shader_compile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-23 17:08 PST by James Darpinian
Modified: 2020-11-30 12:31 PST (History)
14 users (show)

See Also:


Attachments
Patch (24.77 KB, patch)
2020-11-23 17:09 PST, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (33.23 KB, patch)
2020-11-24 15:53 PST, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (33.24 KB, patch)
2020-11-24 16:01 PST, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (33.23 KB, patch)
2020-11-24 16:07 PST, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (33.76 KB, patch)
2020-11-30 11:10 PST, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-11-23 17:08:20 PST
Support KHR_parallel_shader_compile
Comment 1 James Darpinian 2020-11-23 17:09:23 PST
Created attachment 414816 [details]
Patch
Comment 2 Kimmo Kinnunen 2020-11-23 22:39:07 PST
Comment on attachment 414816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414816&action=review

Looks good to me

> Source/WebCore/html/canvas/KHRParallelShaderCompile.h:36
> +    virtual ~KHRParallelShaderCompile();

Nit: maybe the virtual here could be removed and override/final added?
Comment 3 Kenneth Russell 2020-11-24 13:16:34 PST
Comment on attachment 414816 [details]
Patch

Looks good to me modulo Kimmo's feedback. r+
Comment 4 James Darpinian 2020-11-24 15:53:53 PST
Created attachment 414855 [details]
Patch
Comment 5 Kenneth Russell 2020-11-24 16:00:52 PST
Comment on attachment 414855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414855&action=review

Good to see the conformance test and associated fixes. One minor comment about Kimmo's previous review. r+

> Source/WebCore/html/canvas/KHRParallelShaderCompile.h:36
> +    virtual ~KHRParallelShaderCompile();

Kimmo had a comment about marking this final in the last patch set.
Comment 6 James Darpinian 2020-11-24 16:01:46 PST
Created attachment 414856 [details]
Patch
Comment 7 James Darpinian 2020-11-24 16:02:58 PST
Comment on attachment 414816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414816&action=review

Thanks, I updated the patch with a test and a behavior change for the context loss case. The test and spec clarification are also upstream here: https://github.com/KhronosGroup/WebGL/pull/3188

>> Source/WebCore/html/canvas/KHRParallelShaderCompile.h:36
>> +    virtual ~KHRParallelShaderCompile();
> 
> Nit: maybe the virtual here could be removed and override/final added?

Done.
Comment 8 James Darpinian 2020-11-24 16:07:38 PST
Created attachment 414857 [details]
Patch
Comment 9 EWS 2020-11-30 10:24:02 PST
Tools/Scripts/svn-apply failed to apply attachment 414857 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 James Darpinian 2020-11-30 11:10:26 PST
Created attachment 415036 [details]
Patch
Comment 11 EWS 2020-11-30 12:30:01 PST
Committed r270257: <https://trac.webkit.org/changeset/270257>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415036 [details].
Comment 12 Radar WebKit Bug Importer 2020-11-30 12:31:16 PST
<rdar://problem/71817989>