RESOLVED FIXED 219262
Introduce new display list meta commands in preparation for webkit.org/b/219091 
https://bugs.webkit.org/show_bug.cgi?id=219262
Summary Introduce new display list meta commands in preparation for webkit.org/b/219091
Wenson Hsieh
Reported 2020-11-23 11:22:24 PST
More info in ChangeLog
Attachments
Patch (19.75 KB, patch)
2020-11-23 12:16 PST, Wenson Hsieh 		rniwa: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (25.65 KB, patch)
2020-11-24 12:39 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (25.64 KB, patch)
2020-11-24 12:42 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-11-23 12:16:34 PST
Created attachment 414811 [details] Patch
Ryosuke Niwa
Comment 2 2020-11-23 12:30:53 PST
Comment on attachment 414811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review > Source/WebCore/ChangeLog:18 > + `MetaCommandEndOfDisplayList` is used to inform the replayer that it should expect no more display list items; Why not just MetaCommandEnd. OfDisplayList seems redundant. Or maybe MetaCommandPause or MetaCommandWait since we can receive more display list items in the future. > Source/WebCore/ChangeLog:24 > + by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude with a `MetaCommandEndOfDisplayList` item. Change we should rename this to MetaCommandChangeItemBuffer to be consistent although this is really more like MetaCommandContinueInNewItemBuffer.
Wenson Hsieh
Comment 3 2020-11-23 12:56:26 PST
Comment on attachment 414811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review >> Source/WebCore/ChangeLog:18 >> + `MetaCommandEndOfDisplayList` is used to inform the replayer that it should expect no more display list items; > > Why not just MetaCommandEnd. OfDisplayList seems redundant. > Or maybe MetaCommandPause or MetaCommandWait since we can receive more display list items in the future. `MetaCommandEnd` sounds good to me — renamed to that. >> Source/WebCore/ChangeLog:24 >> + by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude with a `MetaCommandEndOfDisplayList` item. > > Change we should rename this to MetaCommandChangeItemBuffer to be consistent > although this is really more like MetaCommandContinueInNewItemBuffer. Makes sense — I'll rename it to `MetaCommandChangeItemBuffer` in this patch for consistency with `MetaCommandChangeDestinationImageBuffer`.
Wenson Hsieh
Comment 4 2020-11-24 12:39:07 PST
Created attachment 414848 [details] Patch
Wenson Hsieh
Comment 5 2020-11-24 12:42:24 PST
Created attachment 414849 [details] Patch
EWS
Comment 6 2020-11-27 12:08:03 PST
Committed r270203: <https://trac.webkit.org/changeset/270203> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414849 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-27 12:09:24 PST
<rdar://problem/71767392>
Note You need to log in before you can comment on or make changes to this bug.