let's use lineBox* helpers instead
Created attachment 414744 [details] Patch
Comment on attachment 414744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414744&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h:62 > - LayoutUnit lineBoxTop() const { return LayoutUnit::fromFloatRound(line().rect().y()); } > - LayoutUnit lineBoxBottom() const { return LayoutUnit::fromFloatRound(line().rect().maxY()); } > + LayoutUnit lineBoxTop() const { return LayoutUnit::fromFloatRound(line().lineBoxTop()); } > + LayoutUnit lineBoxBottom() const { return LayoutUnit::fromFloatRound(line().lineBoxBottom()); } > > // FIXME: What should these really be? > LayoutUnit selectionTop() const { return top(); } > LayoutUnit selectionTopForHitTesting() const { return top(); } > LayoutUnit selectionBottom() const { return bottom(); } > > - float contentLogicalLeft() const { return line().rect().x() + line().contentLeftOffset(); } > + float contentLogicalLeft() const { return line().lineBoxLeft() + line().contentLeftOffset(); } Much better!
Created attachment 414760 [details] Patch
Committed r270146: <https://trac.webkit.org/changeset/270146> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414760 [details].
<rdar://problem/71655183>