Bug 219223 - AXIsolatedTree::m_axObjectCache should not be accessed on the secondary AX thread.
Summary: AXIsolatedTree::m_axObjectCache should not be accessed on the secondary AX th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-20 13:59 PST by Andres Gonzalez
Modified: 2020-11-30 06:11 PST (History)
9 users (show)

See Also:


Attachments
Patch (18.54 KB, patch)
2020-11-20 14:21 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (18.53 KB, patch)
2020-11-22 11:37 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-11-20 13:59:59 PST
AXIsolatedTree::m_axObjectCache should not be accessed on the secondary AX thread.
Comment 1 Andres Gonzalez 2020-11-20 14:21:58 PST
Created attachment 414727 [details]
Patch
Comment 2 chris fleizach 2020-11-21 11:07:22 PST
Comment on attachment 414727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414727&action=review

seems like a good change overall. only comment is that m_usingAXThread is not immediately clear for it's purpose based on the name. 
Does it mean that this Tree can use the AX thread, or it is on the AX thread? Is there a more clear name available?

> Source/WebCore/ChangeLog:10
> +        methods. this problem is fixed with this change by adding the member

this problem > This problem
Comment 3 Andres Gonzalez 2020-11-22 11:37:59 PST
Created attachment 414791 [details]
Patch
Comment 4 Andres Gonzalez 2020-11-22 11:40:11 PST
(In reply to chris fleizach from comment #2)
> Comment on attachment 414727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414727&action=review
> 
> seems like a good change overall. only comment is that m_usingAXThread is
> not immediately clear for it's purpose based on the name. 
> Does it mean that this Tree can use the AX thread, or it is on the AX
> thread? Is there a more clear name available?

Renamed it to m_usedOnAXThread.
> 
> > Source/WebCore/ChangeLog:10
> > +        methods. this problem is fixed with this change by adding the member
> 
> this problem > This problem

Fixed. Thanks!
Comment 5 Radar WebKit Bug Importer 2020-11-27 14:01:31 PST
<rdar://problem/71768053>
Comment 6 EWS 2020-11-30 06:11:25 PST
Committed r270238: <https://trac.webkit.org/changeset/270238>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414791 [details].