Bug 219221 - [GTK][GTK4] Building with GObject-Introspection support does not work
Summary: [GTK][GTK4] Building with GObject-Introspection support does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-11-20 13:39 PST by Adrian Perez
Modified: 2020-11-26 20:22 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2020-11-24 12:30 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-11-20 13:39:40 PST 
Currently we are unconditionally disabling introspection support
if USE_GTK4 is enabled. Removing that restriction from CMake and
configuring with USE_GTK4=ON and ENABLE_INTROSPECTION=ON results
in the following build error:

  (process:18103): GLib-GObject-WARNING **: 19:42:24.462: specified class size for type 'WebKitWebViewBase' is smaller than the parent type's 'GtkWidget' class size
 
  (process:18103): GLib-CRITICAL **: 19:42:24.463: g_once_init_leave: assertion 'result != 0' failed
  Invalid GType function: 'webkit_web_view_base_get_type'
  Function 'webkit_web_view_base_get_type' returned G_TYPE_INVALID
  UIProcess/API/glib/WebKitWebView.cpp:2193: Warning: WebKit2: multiple comment blocks documenting 'WebKitWebView::show-option-menu:' identifier (already seen at WebKitWebView.cpp:2157).
  Command '['/run/build/webkit-gtk4/Source/WebKit/tmp-introspectvo_b70is/WebKit2-5.0', '--introspect-dump=/run/build/webkit-gtk4/Source/WebKit/tmp-introspectvo_b70is/functions.txt,/run/build/webkit-gtk4/Source/WebKit/tmp-introspectvo_b70is/dump.xml']' returned non-zero exit status 1.
Comment 1 Lauro Moura 2020-11-24 12:30:30 PST 
Created attachment 414847 [details]
Patch
Comment 2 EWS 2020-11-26 20:22:17 PST 
Committed r270178: <https://trac.webkit.org/changeset/270178>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414847 [details].