Bug 219220 - [LFC][Integration] Add contentOffset and contentWidth to Line
Summary: [LFC][Integration] Add contentOffset and contentWidth to Line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-20 13:06 PST by zalan
Modified: 2020-11-21 04:58 PST (History)
5 users (show)

See Also:


Attachments
Patch (14.61 KB, patch)
2020-11-20 13:12 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (14.78 KB, patch)
2020-11-20 14:02 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (14.81 KB, patch)
2020-11-20 15:44 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (14.82 KB, patch)
2020-11-20 15:54 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-11-20 13:06:32 PST
This helps to match the legacy root inline box geometry.
Comment 1 zalan 2020-11-20 13:12:23 PST
Created attachment 414709 [details]
Patch
Comment 2 zalan 2020-11-20 14:02:40 PST
Created attachment 414719 [details]
Patch
Comment 3 zalan 2020-11-20 15:44:47 PST
Created attachment 414738 [details]
Patch
Comment 4 zalan 2020-11-20 15:54:09 PST
Created attachment 414739 [details]
Patch
Comment 5 Antti Koivisto 2020-11-20 22:20:18 PST
Comment on attachment 414739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414739&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLine.h:53
> +        , m_contentLeftOffset(contentLeftOffset)
> +        , m_contentWidth(contentWidth)

Could the client just do

content.runs[line.firstRunIndex()].rect().x()
etc

to get the same numbers? I guess having a redundant copy here doesn't hurt.
Comment 6 EWS 2020-11-21 04:57:09 PST
Committed r270143: <https://trac.webkit.org/changeset/270143>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414739 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-21 04:58:16 PST
<rdar://problem/71654468>