RESOLVED FIXED 219203
CSSStyleSheet.cssRules and rules should throw in case of opaque stylesheets 
https://bugs.webkit.org/show_bug.cgi?id=219203
Summary CSSStyleSheet.cssRules and rules should throw in case of opaque stylesheets
youenn fablet
Reported 2020-11-20 07:28:12 PST
CSSStyleSheet.cssRules and rules should throw in case of opaque stylesheets Apparently, that is what Chrome and Firefox are doing.
Attachments
Patch (7.13 KB, patch)
2020-11-20 08:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (8.18 KB, patch)
2020-11-20 08:47 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (11.12 KB, patch)
2020-11-20 14:16 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (11.42 KB, patch)
2020-11-20 14:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (11.10 KB, patch)
2020-11-30 09:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.09 KB, patch)
2020-12-01 00:53 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.17 KB, patch)
2020-12-01 06:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-11-20 08:15:30 PST
Created attachment 414675 [details] Patch
youenn fablet
Comment 2 2020-11-20 08:47:35 PST
Created attachment 414686 [details] Patch
youenn fablet
Comment 3 2020-11-20 14:16:11 PST
Created attachment 414723 [details] Patch
youenn fablet
Comment 4 2020-11-20 14:48:20 PST
Created attachment 414730 [details] Patch
Radar WebKit Bug Importer
Comment 5 2020-11-27 07:29:14 PST
<rdar://problem/71764897>
youenn fablet
Comment 6 2020-11-30 09:09:47 PST
Ping review
Alex Christensen
Comment 7 2020-11-30 09:18:06 PST
Comment on attachment 414730 [details] Patch This removes the canAccessRules check from other callers of rules and cssRules. I think FromJS should be ForJS.
youenn fablet
Comment 8 2020-11-30 09:40:50 PST
Created attachment 415029 [details] Patch
Alex Christensen
Comment 9 2020-11-30 10:04:33 PST
Comment on attachment 415029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415029&action=review > Source/WebCore/css/CSSStyleSheet.cpp:257 > +ExceptionOr<RefPtr<CSSRuleList>> CSSStyleSheet::rulesForJS() This could be ExceptionOr<Ref>
Ryosuke Niwa
Comment 10 2020-11-30 14:26:56 PST
Comment on attachment 415029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415029&action=review > Source/WebCore/css/CSSStyleSheet.h:66 > + ExceptionOr<RefPtr<CSSRuleList>> cssRulesForJS(); > + ExceptionOr<RefPtr<CSSRuleList>> rulesForJS(); ForBindings is the canonical naming convention we use.
youenn fablet
Comment 11 2020-12-01 00:53:28 PST
Created attachment 415108 [details] Patch for landing
youenn fablet
Comment 12 2020-12-01 06:17:43 PST
Created attachment 415132 [details] Patch for landing
EWS
Comment 13 2020-12-01 06:58:34 PST
Committed r270296: <https://trac.webkit.org/changeset/270296> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415132 [details].
Note You need to log in before you can comment on or make changes to this bug.