WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 219198
[GTK] [WPE] Add entries on the bots' /etc/hosts file for testing purpose
https://bugs.webkit.org/show_bug.cgi?id=219198
Summary
[GTK] [WPE] Add entries on the bots' /etc/hosts file for testing purpose
Frédéric Wang (:fredw)
Reported
2020-11-20 03:20:54 PST
This can be a preliminary step for
bug 127676
. It would also allow to rewrite our GTK API test for WebKitInsecureContentEvent without relying on "localhost" and "127.0.0.1" (which are supposed not to be treated as mixed content, see
bug 171934
). Unfortunately Philippe mentioned that /etc/hosts in the flatpak sandbox is readonly. Opening this to track the issue and discuss ideas on how to address it.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2020-11-20 05:55:21 PST
Suggestion: you can write a GResolver that wraps the default GResolver and just specially resolves some extra host. Compile it into a shared object and have the run-[gtk,wpe]-tests scripts set GIO_EXTRA_MODULES to point to it. Then you won't wind up with a test that breaks when not run on a specially-configured bot.
Michael Catanzaro
Comment 2
2021-01-22 07:15:04 PST
(In reply to Michael Catanzaro from
comment #1
)
> Suggestion: you can write a GResolver that wraps the default GResolver and > just specially resolves some extra host. Compile it into a shared object and > have the run-[gtk,wpe]-tests scripts set GIO_EXTRA_MODULES to point to it. > Then you won't wind up with a test that breaks when not run on a > specially-configured bot.
Yeah this seems like a much better approach. It's not *too* complicated, and otherwise the affected tests will never pass when not run on bots. Surely we don't want to tell devs to edit their /etc/hosts.
Patrick Griffis
Comment 3
2022-09-09 09:48:47 PDT
Fixed by
bug 243428
. It now exposes a generic way to add domains for testing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug