Bug 219172 - [webkitscmpy] Support remote repositories in git-webkit
Summary: [webkitscmpy] Support remote repositories in git-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-19 11:31 PST by Jonathan Bedard
Modified: 2020-11-30 11:23 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.07 KB, patch)
2020-11-19 11:44 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (7.08 KB, patch)
2020-11-30 07:50 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (7.08 KB, patch)
2020-11-30 10:52 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-11-19 11:31:50 PST
Now that remote Subversion repositories are supported, we should support running select git-webkit commands with a remote repository.
Comment 1 Radar WebKit Bug Importer 2020-11-19 11:32:01 PST
<rdar://problem/71594909>
Comment 2 Jonathan Bedard 2020-11-19 11:44:48 PST
Created attachment 414608 [details]
Patch
Comment 3 Jonathan Bedard 2020-11-30 07:50:14 PST
Created attachment 415022 [details]
Patch
Comment 4 Aakash Jain 2020-11-30 08:42:30 PST
Comment on attachment 415022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415022&action=review

rs=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program.py:185
> +    if parsed.repository.startswith('https://') or parsed.repository.startswith('http://'):

can use single startswith. 
From https://docs.python.org/3/library/stdtypes.html#str.startswith: "prefix can also be a tuple of prefixes to look for"
Comment 5 Jonathan Bedard 2020-11-30 10:52:20 PST
Created attachment 415033 [details]
Patch
Comment 6 EWS 2020-11-30 11:23:31 PST
Committed r270254: <https://trac.webkit.org/changeset/270254>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415033 [details].