Bug 219164 - [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor
Summary: [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 219197 219233
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-19 08:38 PST by Antti Koivisto
Modified: 2020-11-21 13:55 PST (History)
16 users (show)

See Also:

Attachments
patch (3.42 KB, patch)
2020-11-19 08:42 PST, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (4.75 KB, patch)
2020-11-20 07:30 PST, Antti Koivisto 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (6.13 KB, patch)
2020-11-21 09:48 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (6.13 KB, patch)
2020-11-21 10:01 PST, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-11-19 08:38:47 PST 
It is not needed anymore.
Comment 1 Antti Koivisto 2020-11-19 08:42:21 PST 
Created attachment 414585 [details]
patch
Comment 2 Antti Koivisto 2020-11-20 07:30:12 PST 
Created attachment 414673 [details]
patch
Comment 3 zalan 2020-11-20 07:34:52 PST 
Comment on attachment 414673 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414673&action=review

> Source/WebCore/dom/Position.cpp:-1378
> -void Position::ensureLineBoxes() const
> -{
> -    auto node = deprecatedNode();
> -    if (!node)
> -        return;
> -    auto renderer = node->renderer();
> -    if (!renderer)
> -        return;
> -    auto* parent = renderer->parent();
> -    if (is<RenderBlockFlow>(parent))
> -        downcast<RenderBlockFlow>(*parent).ensureLineBoxes();
> -}
> -

Nice!
Comment 4 Antti Koivisto 2020-11-21 09:48:07 PST 
Created attachment 414762 [details]
patch
Comment 5 Antti Koivisto 2020-11-21 10:01:01 PST 
Created attachment 414764 [details]
patch
Comment 6 EWS 2020-11-21 11:43:35 PST 
Committed r270150: <https://trac.webkit.org/changeset/270150>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414764 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-21 11:44:16 PST 
<rdar://problem/71657035>