Bug 219159 – [macOS] Issue sandbox extension to icon services when starting a drag operation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

Issue sandbox extension to icon services when starting a drag operation on macOS, since the WebContent process needs access to these services when a drag is started.

[Radar WebKit Bug Importer]

<rdar://problem/71585876>

[Per Arne Vollan]

Created attachment 414578 [details]
Patch

[Brent Fulgham]

Comment on attachment 414578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414578&action=review

r=me, but please make sure you revoke the extensions in the early return case.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2834
>      bool shouldHandleEvent = true;

I think there is an early return in the "if !(shouldHandleEvent)" case. You should probably add a revokeSandboxExtensions there, too.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:7060
> +Vector<RefPtr<SandboxExtension>> WebPage::consumeSandboxExtensions(SandboxExtension::HandleArray&& sandboxExtensions)

We do something similar-ish in UserMediaProcessManager::revokeSandboxExtensionsIfNeeded. We might consider a future bug to consolidate the logic.

[Per Arne Vollan]

Created attachment 414976 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 414578 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414578&action=review
> 
> r=me, but please make sure you revoke the extensions in the early return
> case.
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2834
> >      bool shouldHandleEvent = true;
> 
> I think there is an early return in the "if !(shouldHandleEvent)" case. You
> should probably add a revokeSandboxExtensions there, too.
> 

Fixed by consuming the extensions after the early return.

> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:7060
> > +Vector<RefPtr<SandboxExtension>> WebPage::consumeSandboxExtensions(SandboxExtension::HandleArray&& sandboxExtensions)
> 
> We do something similar-ish in
> UserMediaProcessManager::revokeSandboxExtensionsIfNeeded. We might consider
> a future bug to consolidate the logic.

Thanks for reviewing!

[EWS]

Committed r270216: <https://trac.webkit.org/changeset/270216>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414976 [details].