Bug 219116 - 'run-analysis' script should schedule retries for A/B tests even after analysis chart failure.
Summary: 'run-analysis' script should schedule retries for A/B tests even after analys...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-18 14:51 PST by dewei_zhu
Modified: 2020-11-20 17:27 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2020-11-18 14:57 PST, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2020-11-18 14:51:05 PST 
'run-analysis' script should schedule retries for A/B tests even after analysis failure.
Comment 1 dewei_zhu 2020-11-18 14:57:31 PST 
Created attachment 414488 [details]
Patch
Comment 2 Ryosuke Niwa 2020-11-18 17:54:10 PST 
Comment on attachment 414488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414488&action=review

> Websites/perf.webkit.org/tools/run-analysis.js:50
> +        console.error(`Failed analyze measurement sets due to ${error}`);

Failed *to* analyze

> Websites/perf.webkit.org/tools/run-analysis.js:66
> +        console.error(`Failed retry for test group due to ${error}`);

Failed *to retry test groups* due to
Comment 3 dewei_zhu 2020-11-20 17:27:51 PST 
Change is landed in r270140.