Bug 219111 – Remove IRC bots from webkitpy

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

We haven't been running any IRC bots for a while, this is dead code.

[Alexey Proskuryakov]

Created attachment 414482 [details]
proposed patch

[Alexey Proskuryakov]

svn-apply cannot process directory removal, but this is still up for review. What can go wrong without EWS? :)

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #2)
> svn-apply cannot process directory removal, but this is still up for review.
> What can go wrong without EWS? :)

I assume you're run test-webkitpy...that's the one that would break, if anything was going to.

[Jonathan Bedard]

Comment on attachment 414482 [details]
proposed patch

Looks good, assuming webkitpy tests pass.

If we wanted to feel better about EWS, a patch that does not remove third party/irc would still remove the code that we have historically owned, and might have a better chance of applying.

[Aakash Jain]

Looks good. We can also consider removing all instances of 'sheriff-bot' from webkitpy (e.g.: tool/commands/download.py, common/config/contributors.json)

[Alexey Proskuryakov]

(In reply to Aakash Jain from comment #5)
> Looks good. We can also consider removing all instances of 'sheriff-bot'
> from webkitpy (e.g.: tool/commands/download.py,
> common/config/contributors.json)

It's also mentioned in Tools/WebKitBot/src/WebKitBot.mjs, so I wasn't sure how to confirm that it's OK to remove.

[Alexey Proskuryakov]

But I'm fairly sure that what I'm removing is unused. CC'ing bot watchers in case I do break the Slack bot somehow.

[Alexey Proskuryakov]

Committed http://trac.webkit.org/r270003

[Radar WebKit Bug Importer]

<rdar://problem/71564617>