Bug 219103 - [iOS][FCR] Add new look for meter element
Summary: [iOS][FCR] Add new look for meter element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on: 219046
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-18 11:51 PST by Aditya Keerthi
Modified: 2020-11-27 13:32 PST (History)
10 users (show)

See Also:

Attachments
Patch (19.71 KB, patch)
2020-11-18 11:55 PST, Aditya Keerthi 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (19.68 KB, patch)
2020-11-27 09:08 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-11-18 11:51:58 PST 
...
Comment 1 Aditya Keerthi 2020-11-18 11:52:14 PST 
<rdar://problem/71549155>
Comment 2 Aditya Keerthi 2020-11-18 11:55:14 PST 
Created attachment 414465 [details]
Patch
Comment 3 Aditya Keerthi 2020-11-18 11:58:27 PST 
Patch will apply once https://bugs.webkit.org/show_bug.cgi?id=219046 has landed.
Comment 4 Wenson Hsieh 2020-11-20 13:23:41 PST 
Comment on attachment 414465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414465&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2092
> +    auto* element = renderMeter.meterElement();

Nit - I /think/ we prefer RefPtr over raw pointers like this in new code (i.e. auto element = makeRefPtr(renderMeter.meterElement());)
Comment 5 Aditya Keerthi 2020-11-27 09:08:04 PST 
Created attachment 414949 [details]
Patch for landing
Comment 6 EWS 2020-11-27 13:32:21 PST 
Committed r270207: <https://trac.webkit.org/changeset/270207>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414949 [details].