Bug 219098 – Use final in generated wrapper owner code

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Don Olmstead]

Generated bindings should use override when appropriate.

[Don Olmstead]

Created attachment 414463 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 414463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414463&action=review

r=me with one suggestion.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230
>          push(@headerContent, "public:\n");

How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I don't think anyone is inheriting this class.

[Don Olmstead]

(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 414463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414463&action=review
> 
> r=me with one suggestion.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230
> >          push(@headerContent, "public:\n");
> 
> How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I
> don't think anyone is inheriting this class.

I'm going to split this patch into two parts since there was a bit more surgery required to accommodate this change.

[Don Olmstead]

Created attachment 414594 [details]
Patch

[Don Olmstead]

Created attachment 414598 [details]
Patch

[EWS]

Committed r270042: <https://trac.webkit.org/changeset/270042>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414598 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71596160>