Big Sur testers failing to download build products python ./Tools/CISupport/download-built-product --platform=mac --release 'https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 arm64-release/269963.zip' ... ... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 505 HTTP Version not supported https://build.webkit.org/builders/Apple-BigSur-Release-WK2-Tests/builds/44
<rdar://problem/71545314>
Looks like this is due to the space in the URL. Not sure how we archived the build product with a space, but we can fix it with a '+' in place of the space.
Created attachment 414468 [details] Patch
Created attachment 414469 [details] Patch
re-uploaded for copyright fix
Created attachment 414474 [details] Patch
At the request offline. Added python3 support. Also both quote and quote_plus work.
Comment on attachment 414474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414474&action=review > Tools/CISupport/download-built-product:32 > +try: Instead of try except, it might be a good idea to use sys.version_info like: https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/path.py#L39
Created attachment 414475 [details] Patch
Comment on attachment 414475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414475&action=review > Tools/CISupport/download-built-product:3 > +# Copyright (C) 2009,2020 Apple Inc. All rights reserved. Nit: missing space after comma.
Created attachment 414480 [details] Patch for landing
Committed r269988: <https://trac.webkit.org/changeset/269988> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414480 [details].