Bug 219092 – check-webkit-style should require spaces around the equal sign for Objective-C @synthesize

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Hoa Dinh]

Currently, check-webkit-style will require to have no spaces around the equal sign for "@synthesize a = b".
The codebase shows that "@synthesize a=b" is preferred.

Let's improve check-webkit-style to match what we use.

[Hoa Dinh]

Created attachment 414455 [details]
Patch

[Jonathan Bedard]

Comment on attachment 414455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414455&action=review

> Tools/ChangeLog:3
> +        check-webkit-style: requires spaces around the equal sign for

Should be on a single line

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2208
> +                  'Should have spaces around = in property synthesis.')

I don't have an issue with the change, but I also don't do much workin Objective-C....someone who has more experience in the area should verify this is actually what we want to do.

[Wenson Hsieh]

Comment on attachment 414455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414455&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2109
> +        self.assert_lint('@synthesize a=b;', 'Should have spaces around = in property synthesis.  [whitespace/property] [4]')

It looks like there are currently about 90 instances of `@synthesize foo=bar` in the WebKit stack — we should probably update these if we're changing the style rules for synthesized properties.

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 414455 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414455&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2109
> > +        self.assert_lint('@synthesize a=b;', 'Should have spaces around = in property synthesis.  [whitespace/property] [4]')
> 
> It looks like there are currently about 90 instances of `@synthesize
> foo=bar` in the WebKit stack — we should probably update these if we're
> changing the style rules for synthesized properties.

(...but I suppose this could be done separately)

[Hoa Dinh]

Created attachment 414458 [details]
Patch

[Wenson Hsieh]

Comment on attachment 414458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414458&action=review

> Tools/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Ideally, there should be a sentence or two below the "Reviewed by" line describing the change. Maybe something like along the lines of:

```
Teach the Objective-C style checker to prefer `@synthesize a = b` over `@synthesize a=b`. As a followup,
<webkit.org/b/219094> will enforce this style rule in existing @synthesize statements in WebKit.
```

[Hoa Dinh]

Created attachment 414603 [details]
Patch

[EWS]

Committed r270068: <https://trac.webkit.org/changeset/270068>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414603 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71615614>