Bug 219081 – [GTK] MiniBrowser: add an option to quit the browser after loading finishes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

It's useful to run benchmarks or test case reduction tools

[Carlos Garcia Campos]

Created attachment 414444 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 414444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414444&action=review

> Tools/MiniBrowser/gtk/main.c:594
> +static void exitAfterWebProcessCrashed(WebKitWebView *webView, WebKitWebProcessTerminationReason reason, GApplication *application)
> +{
> +    if (reason == WEBKIT_WEB_PROCESS_CRASHED)
> +        exitAfterWebViewLoadFinishesCallback(webView, WEBKIT_LOAD_FINISHED, application);

In this case I think it will be useful to print an error message saying that the webprocess has crashed.
Otherwise it can be confusing, and the user can't easily tell if the minibrowser is exiting because the load has finished correctly or because of a crash from the webprocess.
Also setting a non-zero exit code in this case can be also useful for tests.

[Carlos Garcia Campos]

Comment on attachment 414444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414444&action=review

>> Tools/MiniBrowser/gtk/main.c:594
>> +        exitAfterWebViewLoadFinishesCallback(webView, WEBKIT_LOAD_FINISHED, application);
> 
> In this case I think it will be useful to print an error message saying that the webprocess has crashed.
> Otherwise it can be confusing, and the user can't easily tell if the minibrowser is exiting because the load has finished correctly or because of a crash from the webprocess.
> Also setting a non-zero exit code in this case can be also useful for tests.

The message is always printed by the webProcessTerminatedCallback() in BrowserTab.c. I think it's a good idea to exit(1) instead of g_application_quit().

[Carlos Garcia Campos]

Committed r270186: <https://trac.webkit.org/changeset/270186>