Bug 219080 - Support <source> as a child of <model> to specify the current source
Summary: Support <source> as a child of <model> to specify the current source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-18 05:13 PST by Antoine Quint
Modified: 2020-11-18 09:46 PST (History)
9 users (show)

See Also:

Attachments
Patch (11.14 KB, patch)
2020-11-18 05:19 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-11-18 05:13:48 PST 
Support <source> as a child of <model> to specify the current source
Comment 1 Antoine Quint 2020-11-18 05:19:57 PST 
Created attachment 414441 [details]
Patch
Comment 2 Dean Jackson 2020-11-18 09:13:57 PST 
Comment on attachment 414441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414441&action=review

> Source/WebCore/html/HTMLModelElement.cpp:79
> +void HTMLModelElement::didMoveToNewDocument(Document& oldDocument, Document& newDocument)

Why would this change the source children? I guess their relative URLs may have changed?
Comment 3 Antoine Quint 2020-11-18 09:27:35 PST 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 414441 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414441&action=review
> 
> > Source/WebCore/html/HTMLModelElement.cpp:79
> > +void HTMLModelElement::didMoveToNewDocument(Document& oldDocument, Document& newDocument)
> 
> Why would this change the source children? I guess their relative URLs may
> have changed?

Yes. I think this could also alter the availability of a browsing context?
Comment 4 EWS 2020-11-18 09:45:43 PST 
Committed r269962: <https://trac.webkit.org/changeset/269962>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414441 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-18 09:46:19 PST 
<rdar://problem/71543368>