Bug 219078 - [GStreamer] GStreamerRegistryScanner cleanups and improvements
Summary: [GStreamer] GStreamerRegistryScanner cleanups and improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-18 04:42 PST by Carlos Garcia Campos
Modified: 2020-11-19 11:44 PST (History)
8 users (show)

See Also:

Attachments
Patch (44.58 KB, patch)
2020-11-18 04:53 PST, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-11-18 04:42:56 PST 
We are creating the factories and keeping them alive forever, because GStreamerRegistryScanner is singleton. We can just delete them after the initialization and then create the factories we need on demand when checking AV! codecs.
Comment 1 Carlos Garcia Campos 2020-11-18 04:53:44 PST 
Created attachment 414438 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-11-19 00:54:54 PST 
Committed r270019: <https://trac.webkit.org/changeset/270019>
Comment 3 Radar WebKit Bug Importer 2020-11-19 00:55:16 PST 
<rdar://problem/71577999>
Comment 4 Lauro Moura 2020-11-19 11:44:37 PST 
The usage of OptionSet with All (`(1 << 8) - 1`) was asserting in debug:

https://build.webkit.org/results/WPE-Linux-64-bit-Debug-Tests/r270023%20(5273)/css1/basic/contextual_selectors-crash-log.txt

https://build.webkit.org/results/WPE-Linux-64-bit-Debug-Tests/r270023%20(5273)/results.html

Tentative fix pushed in r270039 using fromRaw as suggested by Philippe.