In Chromium bug http:///crbug.com/1149176 it was pointed out that enabling the RASTERIZER_DISCARD state interferes with the WebGL context's implicit auto-clears. A conformance test for this was just added in https://github.com/KhronosGroup/WebGL/pull/3183 ; WebKit needs fixes in this area as well.
Created attachment 414410 [details] Patch
Could I ask for a little help with the above patch? The new test fails in TestRunner, though it passes in MiniBrowser. I gather there are compositing differences in the test runner, but couldn't figure out if there are any Internals methods that can force a composite, for example.
Created attachment 414717 [details] Patch
Removed the new WebGL conformance test as a layout test after discussion with dino and kkinnunen - TestRunner doesn't pass it, but the browser and MiniBrowser do. Will do follow-on work on that.
Comment on attachment 414717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414717&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:467 > + : m_context(context), m_wasEnabled(wasEnabled) Nit: we do this on two lines. > Source/WebCore/html/canvas/WebGLRenderingContextBase.h:650 > + bool m_rasterizerDiscardEnabled; Not necessary now, but we should probably go through these and give them default values.
Comment on attachment 414717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414717&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:467 >> + : m_context(context), m_wasEnabled(wasEnabled) > > Nit: we do this on two lines. Done. >> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:650 >> + bool m_rasterizerDiscardEnabled; > > Not necessary now, but we should probably go through these and give them default values. Yes, let's do that - strongly prefer that style. Fixed this new one.
Created attachment 414815 [details] Patch
Comment on attachment 414815 [details] Patch Forgot that the repo's closed this week.
<rdar://problem/71747708>
Comment on attachment 414815 [details] Patch Attempting cq+.
Committed r270253: <https://trac.webkit.org/changeset/270253> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414815 [details].
For what it's worth, I analyzed the layout test failures seen by the EWS as being unrelated to this patch. Please tell me if that seems to not be the case.