Bug 219043 - [CMake] generate_offset_extractor.rb missing build dependency for llint/WebAssembly.asm
Summary: [CMake] generate_offset_extractor.rb missing build dependency for llint/WebAs...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2020-11-17 11:32 PST by Michael Catanzaro
Modified: 2020-11-17 16:07 PST (History)
14 users (show)

See Also:

Patch (1.30 KB, patch)
2020-11-17 15:34 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-11-17 11:32:17 PST
Trying to guess why EWS is failing in bug #210302, I noticed that generate_offset_extractor.rb is missing a build dependency for llint/WebAssembly.asm.

Sadly, this doesn't explain the build failure in that bug, because that patch modifies several other files that should cause this script to run. But let's fix it anyway.
Comment 1 Michael Catanzaro 2020-11-17 11:38:17 PST
My working dir is pretty dirty right now. The fix I will upload when ready is:

diff --git a/Source/JavaScriptCore/CMakeLists.txt b/Source/JavaScriptCore/CMakeLists.txt
index 38ae6ce11a89..82311f380df2 100644
--- a/Source/JavaScriptCore/CMakeLists.txt
+++ b/Source/JavaScriptCore/CMakeLists.txt
@@ -192,6 +192,7 @@ set(LLINT_ASM
+    llint/WebAssembly.asm
Comment 2 Michael Catanzaro 2020-11-17 15:34:45 PST
Created attachment 414392 [details]
Comment 3 EWS 2020-11-17 16:04:39 PST
Committed r269933: <https://trac.webkit.org/changeset/269933>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414392 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-17 16:07:53 PST