RESOLVED FIXED 219041
[macOS] Issue sandbox extension to Web Inspector service 
https://bugs.webkit.org/show_bug.cgi?id=219041
Summary [macOS] Issue sandbox extension to Web Inspector service
Per Arne Vollan
Reported 2020-11-17 11:25:31 PST
In preparation of blocking this service in the WebContent process, a sandbox extension should be issued if Safari's Develop menu is enabled.
Attachments
Patch (14.19 KB, patch)
2020-11-17 11:39 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (14.26 KB, patch)
2020-11-19 09:03 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-17 11:25:50 PST
<rdar://problem/71495287>
Per Arne Vollan
Comment 2 2020-11-17 11:39:02 PST
Created attachment 414359 [details] Patch
Brent Fulgham
Comment 3 2020-11-18 16:52:28 PST
Comment on attachment 414359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414359&action=review r=me > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:209 > + if (!CFPreferencesGetAppIntegerValue(CFSTR("ShowDevelopMenu"), CFSTR("com.apple.Safari.SandboxBroker"), nullptr)) It's a shame we couldn't reuse WIRRemoteInspectorEnabledKey here (i.e., define this differently on non-IOS_FAMILY). > Tools/MiniBrowser/MiniBrowser.entitlements:29 > + <string>com.apple.Safari.SandboxBroker</string> Do we need this for WebKitTestRunner?
Per Arne Vollan
Comment 4 2020-11-19 09:03:21 PST
Created attachment 414589 [details] Patch
Per Arne Vollan
Comment 5 2020-11-19 09:04:17 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 414359 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414359&action=review > > r=me > > > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:209 > > + if (!CFPreferencesGetAppIntegerValue(CFSTR("ShowDevelopMenu"), CFSTR("com.apple.Safari.SandboxBroker"), nullptr)) > > It's a shame we couldn't reuse WIRRemoteInspectorEnabledKey here (i.e., > define this differently on non-IOS_FAMILY). > > > Tools/MiniBrowser/MiniBrowser.entitlements:29 > > + <string>com.apple.Safari.SandboxBroker</string> > > Do we need this for WebKitTestRunner? I don't believe so, since WebKitTestRunner is not sandboxed, AFAIK. Thanks for reviewing!
EWS
Comment 6 2020-11-19 09:32:47 PST
Committed r270035: <https://trac.webkit.org/changeset/270035> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414589 [details].
Note You need to log in before you can comment on or make changes to this bug.