NEW 219033
StringBuilder append(const String& string) has a few redundant checks 
https://bugs.webkit.org/show_bug.cgi?id=219033
Summary StringBuilder append(const String& string) has a few redundant checks
xc.o.c.1180@gmail.com
Reported 2020-11-17 07:27:42 PST
Created attachment 414337 [details] Proposed patch. After 'if (!string.length())', string's StringImpl can not be null, a few null checks can be skipped by using StringImpl reference. Please see patch for details. Thanks.
Attachments
Proposed patch. (2.41 KB, patch)
2020-11-17 07:27 PST, xc.o.c.1180@gmail.com 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-18 10:37:16 PST
<rdar://problem/71545904>
Darin Adler
Comment 2 2020-11-18 18:41:20 PST
Comment on attachment 414337 [details] Proposed patch. Yes, looks OK. Since it makes the code slightly less elegant, and I am not sure it will make things more efficient on any platform, I am not sure we should make the change.
Note You need to log in before you can comment on or make changes to this bug.