Bug 219026 - Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
Summary: Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_4...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 218637
Blocks: 219030
  Show dependency tree / graph
 
Reported: 2020-11-17 01:38 PST by Kimmo Kinnunen
Modified: 2020-11-17 06:20 PST (History)
14 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2020-11-17 01:51 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (4.20 KB, patch)
2020-11-17 02:33 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (4.29 KB, patch)
2020-11-17 02:47 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2020-11-17 01:38:41 PST 
Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
Comment 1 Kimmo Kinnunen 2020-11-17 01:51:42 PST 
Created attachment 414320 [details]
Patch
Comment 2 Antti Koivisto 2020-11-17 02:12:59 PST 
Comment on attachment 414320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414320&action=review

> Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h:30
> +#if USE(APPLE_INTERNAL_SDK) && HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)

Might be better to ifdef the call site?
Comment 3 Kimmo Kinnunen 2020-11-17 02:33:51 PST 
Created attachment 414325 [details]
Patch
Comment 4 Antti Koivisto 2020-11-17 02:34:40 PST 
Comment on attachment 414325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414325&action=review

> Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h:30
> +#if USE(APPLE_INTERNAL_SDK) && HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)

This shouldn't be needed now.
Comment 5 Kimmo Kinnunen 2020-11-17 02:47:39 PST 
Created attachment 414327 [details]
Patch
Comment 6 EWS 2020-11-17 06:07:22 PST 
Committed r269898: <https://trac.webkit.org/changeset/269898>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414327 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-17 06:08:21 PST 
<rdar://problem/71484045>