Bug 219021 – Add a default action for SpeechRecognition permission request

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Sihui Liu]

...

[Sihui Liu]

Created attachment 414306 [details]
Patch

[youenn fablet]

Comment on attachment 414306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414306&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm:29
>  #if ENABLE(MEDIA_STREAM)

UserMediaPermissionRequestProxy.mm can probably be removed if we move the alter code in MediaPermissionUtilities.mm.

> Source/WebKit/UIProcess/MediaPermissionUtilities.h:77
> +template<> struct EnumTraits<WebKit::MediaPermissionType> {

Do we need to send this over IPC?

> Source/WebKit/UIProcess/WebPageProxy.cpp:10251
> +void WebPageProxy::decidePolicyForSpeechRecognitionPermission(const WebCore::SecurityOrigin& origin, CompletionHandler<void(bool)>&& completionHandler)

Maybe the name could be more descriptive here. I don't have a good name though.

[Sihui Liu]

(In reply to youenn fablet from comment #2)
> Comment on attachment 414306 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414306&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm:29
> >  #if ENABLE(MEDIA_STREAM)
> 
> UserMediaPermissionRequestProxy.mm can probably be removed if we move the
> alter code in MediaPermissionUtilities.mm.

Yes, will try removing it.

> 
> > Source/WebKit/UIProcess/MediaPermissionUtilities.h:77
> > +template<> struct EnumTraits<WebKit::MediaPermissionType> {
> 
> Do we need to send this over IPC?

Nope, will remove.

> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:10251
> > +void WebPageProxy::decidePolicyForSpeechRecognitionPermission(const WebCore::SecurityOrigin& origin, CompletionHandler<void(bool)>&& completionHandler)
> 
> Maybe the name could be more descriptive here. I don't have a good name
> though.

hmm, will change to requestSpeechRecognitionPermissionByDefaultAction.

[Sihui Liu]

Created attachment 414352 [details]
Patch

[Sihui Liu]

Created attachment 414354 [details]
Patch

[Sihui Liu]

Created attachment 414356 [details]
Patch

[EWS]

Committed r269918: <https://trac.webkit.org/changeset/269918>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414356 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71499713>