BuildBotTriggerable should not process a completed build request from a completed test group.
Created attachment 414298 [details]
Comment on attachment 414298 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=414298&action=review
> + BuildBotTriggerable._pullBuildbotOnAllSyncers assumes BuildRequest.all() retuns all build requests from triggerables.
> + And it relies on BuildRequest.findById to filter out buildbot build entries and corresponding build requests from a
This explanation is rather misleading.
The issue here isn't really that _pullBuildbotOnAllSyncers assumes that but it's rather that
it relies on buildReqeustsByGroup to contain all build requests found by BuildRequest.findById.
> + if (!info)
> + continue;
We should probably assert here that in this case, request's test group had finished running.
Landed in r269892.