Bug 219016 - BuildbotTriggerable should not process a completed build request from a completed test group.
Summary: BuildbotTriggerable should not process a completed build request from a compl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-16 18:47 PST by dewei_zhu
Modified: 2020-11-16 20:33 PST (History)
1 user (show)

See Also:

Attachments
Patch (8.51 KB, patch)
2020-11-16 19:04 PST, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2020-11-16 18:47:17 PST 
BuildBotTriggerable should not process a completed build request from a completed test group.
Comment 1 dewei_zhu 2020-11-16 19:04:11 PST 
Created attachment 414298 [details]
Patch
Comment 2 Ryosuke Niwa 2020-11-16 19:30:19 PST 
Comment on attachment 414298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414298&action=review

> Websites/perf.webkit.org/ChangeLog:9
> +        BuildBotTriggerable._pullBuildbotOnAllSyncers assumes BuildRequest.all() retuns all build requests from triggerables.
> +        And it relies on BuildRequest.findById to filter out buildbot build entries and corresponding build requests from a

This explanation is rather misleading.
The issue here isn't really that _pullBuildbotOnAllSyncers assumes that but it's rather that
it relies on buildReqeustsByGroup to contain all build requests found by BuildRequest.findById.

> Websites/perf.webkit.org/tools/js/buildbot-triggerable.js:182
> +                    if (!info)
> +                        continue;

We should probably assert here that in this case, request's test group had finished running.
Comment 3 dewei_zhu 2020-11-16 20:33:50 PST 
Landed in r269892.