Bug 219002 - [GPUProcess] Update GPUProcess process assertion based on active WebProcesses
Summary: [GPUProcess] Update GPUProcess process assertion based on active WebProcesses
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2020-11-16 13:17 PST by Chris Dumez
Modified: 2020-11-16 16:15 PST (History)
5 users (show)

See Also:

Patch (2.70 KB, patch)
2020-11-16 13:19 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-11-16 13:17:26 PST
Update GPUProcess process assertion based on active WebProcesses, similarly to what we do for the network process.
Comment 1 Chris Dumez 2020-11-16 13:19:36 PST
Created attachment 414274 [details]
Comment 2 EWS 2020-11-16 14:17:46 PST
Committed r269879: <https://trac.webkit.org/changeset/269879>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414274 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-16 14:18:18 PST
Comment 4 Darin Adler 2020-11-16 16:15:39 PST
Comment on attachment 414274 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=414274&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:288
> +    // Use std::exchange() instead of a simple nullptr assignment to avoid re-entering this
> +    // function during the destructor of the ProcessThrottler activity, before setting
> +    // m_activityFromWebProcesses.
> +    std::exchange(m_activityFromWebProcesses, nullptr);

Could this be fixed by changing the Variant implementation instead? I remember something similar for our smart pointers and we fixed that in the smart pointer class rather than at call sites.