Bug 218997 - NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds
Summary: NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-16 12:18 PST by John Wilander
Modified: 2020-11-16 15:52 PST (History)
1 user (show)

See Also:

Attachments
Patch for landing (2.29 KB, patch)
2020-11-16 15:01 PST, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-11-16 12:18:33 PST 
NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds. We should change the format specifier from %s to %{public}s. Note that this logging is just for ITP Debug Mode which is off by default, logs in-memory only, and is disabled again on browser quit.
Comment 1 Radar WebKit Bug Importer 2020-11-16 14:53:45 PST 
<rdar://problem/71460604>
Comment 2 John Wilander 2020-11-16 15:01:28 PST 
Created attachment 414281 [details]
Patch for landing
Comment 3 EWS 2020-11-16 15:52:11 PST 
Committed r269885: <https://trac.webkit.org/changeset/269885>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414281 [details].