Bug 218991 - Add an experimental <model> element
Summary: Add an experimental <model> element
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on:
Reported: 2020-11-16 10:14 PST by Antoine Quint
Modified: 2020-11-17 03:35 PST (History)
17 users (show)

See Also:

Patch (22.65 KB, patch)
2020-11-16 10:18 PST, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.18 KB, patch)
2020-11-16 10:54 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-11-16 10:14:03 PST
Add an experimental <model> element
Comment 1 Antoine Quint 2020-11-16 10:18:49 PST
Created attachment 414249 [details]
Comment 2 Antoine Quint 2020-11-16 10:54:45 PST
Created attachment 414256 [details]
Comment 3 EWS 2020-11-16 14:40:49 PST
Committed r269880: <https://trac.webkit.org/changeset/269880>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414256 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-16 14:41:18 PST
Comment 5 Simon Fraser (smfr) 2020-11-16 15:02:21 PST
Comment on attachment 414256 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=414256&action=review

> LayoutTests/ChangeLog:8
> +        Add a new system-preview/model subdirectory for <model> tests, which we run on macOS and iOS.

Why "system-preview"? You're adding an HTML element, which doesn't sound like a system-preview.
Comment 6 Antoine Quint 2020-11-17 03:35:08 PST
This shouldn't have been made enabled if ENABLE(EXPERIMENTAL_FEATURES) since this enables in STP as well. We really want this to be opt-in completely, even if that requires opting into the feature in tests as well. I'll correct this in bug 219027.