WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
218991
Add an experimental <model> element
https://bugs.webkit.org/show_bug.cgi?id=218991
Summary
Add an experimental <model> element
Antoine Quint
Reported
2020-11-16 10:14:03 PST
Add an experimental <model> element
Attachments
Patch
(22.65 KB, patch)
2020-11-16 10:18 PST
,
Antoine Quint
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(23.18 KB, patch)
2020-11-16 10:54 PST
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2020-11-16 10:18:49 PST
Created
attachment 414249
[details]
Patch
Antoine Quint
Comment 2
2020-11-16 10:54:45 PST
Created
attachment 414256
[details]
Patch
EWS
Comment 3
2020-11-16 14:40:49 PST
Committed
r269880
: <
https://trac.webkit.org/changeset/269880
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 414256
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-11-16 14:41:18 PST
<
rdar://problem/71460062
>
Simon Fraser (smfr)
Comment 5
2020-11-16 15:02:21 PST
Comment on
attachment 414256
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=414256&action=review
> LayoutTests/ChangeLog:8 > + Add a new system-preview/model subdirectory for <model> tests, which we run on macOS and iOS.
Why "system-preview"? You're adding an HTML element, which doesn't sound like a system-preview.
Antoine Quint
Comment 6
2020-11-17 03:35:08 PST
This shouldn't have been made enabled if ENABLE(EXPERIMENTAL_FEATURES) since this enables in STP as well. We really want this to be opt-in completely, even if that requires opting into the feature in tests as well. I'll correct this in
bug 219027
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug