Bug 218975 – [css-flex] Images as flex items should use the overridingLogicalHeight when defined to compute the logical width

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

RenderReplaced should use the overridingLogicalHeight when defined to compute the logical width

[Sergio Villar Senin]

Created attachment 414213 [details]
Patch

[Sergio Villar Senin]

Created attachment 414322 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 414322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414322&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:527
> +            ASSERT(intrinsicRatio);

intrisicRatio can be zero, so this ASSERT will crash (like it's happening on the debug EWS), Shouldn't we add it in the previous check?

[Sergio Villar Senin]

(In reply to Manuel Rego Casasnovas from comment #3)
> Comment on attachment 414322 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414322&action=review
> 
> > Source/WebCore/rendering/RenderReplaced.cpp:527
> > +            ASSERT(intrinsicRatio);
> 
> intrisicRatio can be zero, so this ASSERT will crash (like it's happening on
> the debug EWS), Shouldn't we add it in the previous check?

I'm trying to know how intrinsicRatio is zero given that both the intrinsic width and the intrinsic height are > 0. I thought it won't be possible, that's why I added the ASSERT.

[Sergio Villar Senin]

(In reply to Sergio Villar Senin from comment #4)
> (In reply to Manuel Rego Casasnovas from comment #3)
> > Comment on attachment 414322 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=414322&action=review
> > 
> > > Source/WebCore/rendering/RenderReplaced.cpp:527
> > > +            ASSERT(intrinsicRatio);
> > 
> > intrisicRatio can be zero, so this ASSERT will crash (like it's happening on
> > the debug EWS), Shouldn't we add it in the previous check?
> 
> I'm trying to know how intrinsicRatio is zero given that both the intrinsic
> width and the intrinsic height are > 0. I thought it won't be possible,
> that's why I added the ASSERT.

Right so for example an iframe has indeed a intrinsic size but not necessarily an aspect ratio. Will change the condition and remove the assert

[Sergio Villar Senin]

Created attachment 414442 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 414442 [details]
Patch

r=me

[Sergio Villar Senin]

Committed r270073: <https://trac.webkit.org/changeset/270073>

[Radar WebKit Bug Importer]

<rdar://problem/71620147>