WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
218967
PCM: Change attribute and JSON key names according to the W3C conversation
https://bugs.webkit.org/show_bug.cgi?id=218967
Summary
PCM: Change attribute and JSON key names according to the W3C conversation
John Wilander
Reported
2020-11-15 18:03:08 PST
We’ve discussed extensively with Google and others on naming for the link attributes and JSON key names in these issues:
https://github.com/privacycg/private-click-measurement/issues/30
https://github.com/privacycg/private-click-measurement/issues/56
We should change PCM accordingly.
Attachments
Patch
(36.09 KB, patch)
2020-11-15 18:08 PST
,
John Wilander
no flags
Details
Formatted Diff
Diff
Patch
(37.22 KB, patch)
2020-11-16 11:27 PST
,
John Wilander
no flags
Details
Formatted Diff
Diff
Patch
(40.49 KB, patch)
2020-11-16 12:33 PST
,
John Wilander
no flags
Details
Formatted Diff
Diff
Patch for landing
(40.48 KB, patch)
2020-11-16 15:07 PST
,
John Wilander
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
John Wilander
Comment 1
2020-11-15 18:03:30 PST
<
rdar://problem/71422345
>
John Wilander
Comment 2
2020-11-15 18:08:46 PST
Created
attachment 414186
[details]
Patch
John Wilander
Comment 3
2020-11-16 11:27:42 PST
Created
attachment 414260
[details]
Patch
John Wilander
Comment 4
2020-11-16 12:33:54 PST
Created
attachment 414268
[details]
Patch
John Wilander
Comment 5
2020-11-16 13:40:31 PST
win build failure looks unrelated.
John Wilander
Comment 6
2020-11-16 14:22:45 PST
ios-wk2 test failure is unrelated.
Brent Fulgham
Comment 7
2020-11-16 14:57:35 PST
Comment on
attachment 414268
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=414268&action=review
Looks good. Nice to have the spec coming together! r=me.
> Source/WebCore/ChangeLog:8 > + Weâve discussed extensively with Google and others on naming for the link
Looks like you got a smart-quote in here.
> Source/WebCore/html/HTMLAnchorElement.cpp:426 > + document().addConsoleMessage(MessageSource::Other, MessageLevel::Warning, "Both attributionsourceid and attributeon need to be set for Private Click Measurement to work."_s);
I know that this is correct, but at first I thought "attributeon" was misspelled.
> Source/WebCore/html/HTMLAttributeNames.in:70 > +attributeon
I wish this had been spec'd as "attribute-on"
John Wilander
Comment 8
2020-11-16 15:04:04 PST
(In reply to Brent Fulgham from
comment #7
)
> Comment on
attachment 414268
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=414268&action=review
> > Looks good. Nice to have the spec coming together! r=me. > > > Source/WebCore/ChangeLog:8 > > + Weâve discussed extensively with Google and others on naming for the link > > Looks like you got a smart-quote in here.
Good catch. Will fix.
> > Source/WebCore/html/HTMLAnchorElement.cpp:426 > > + document().addConsoleMessage(MessageSource::Other, MessageLevel::Warning, "Both attributionsourceid and attributeon need to be set for Private Click Measurement to work."_s); > > I know that this is correct, but at first I thought "attributeon" was > misspelled. > > > Source/WebCore/html/HTMLAttributeNames.in:70 > > +attributeon > > I wish this had been spec'd as "attribute-on"
I agree but Google referred to this TAG document (see "HTML elements and attributes"):
https://w3ctag.github.io/design-principles/#casing-rules
Thanks for the review!
John Wilander
Comment 9
2020-11-16 15:07:09 PST
Created
attachment 414282
[details]
Patch for landing
EWS
Comment 10
2020-11-16 16:00:55 PST
Committed
r269886
: <
https://trac.webkit.org/changeset/269886
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 414282
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug