Bug 218966 - Remove and re-add fast/forms/selection-direction.html without CRs
Summary: Remove and re-add fast/forms/selection-direction.html without CRs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-15 16:00 PST by Sam Weinig
Modified: 2020-11-16 09:05 PST (History)
2 users (show)

See Also:


Attachments
Remove test temporarily (4.64 KB, patch)
2020-11-15 16:01 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-11-15 16:00:22 PST
fast/forms/selection-direction.html has CR line ending and the scripts won't allow me to change it. They will allow me to remove it though, so let's remove it and add it back without the line endings.
Comment 1 Sam Weinig 2020-11-15 16:01:55 PST
Created attachment 414184 [details]
Remove test temporarily
Comment 2 EWS 2020-11-15 16:33:50 PST
Committed r269834: <https://trac.webkit.org/changeset/269834>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414184 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-15 16:34:19 PST
<rdar://problem/71421831>
Comment 4 Darin Adler 2020-11-15 16:39:26 PST
Seems like we didn’t need to use a bug and commit-queue for this. Could just use git/svn directly.
Comment 5 Sam Weinig 2020-11-16 08:54:02 PST
(In reply to Darin Adler from comment #4)
> Seems like we didn’t need to use a bug and commit-queue for this. Could just
> use git/svn directly.

Yeah, I didn't think it through. Should have done that.
Comment 6 Sam Weinig 2020-11-16 09:05:08 PST
Added test back in https://trac.webkit.org/changeset/269854/webkit.