Bug 218958 - Add logging of AXCoreObject outerHTML to AXLogger.
Summary: Add logging of AXCoreObject outerHTML to AXLogger.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-15 09:36 PST by Andres Gonzalez
Modified: 2020-11-16 10:13 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2020-11-15 09:43 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (2.34 KB, patch)
2020-11-16 06:40 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-11-15 09:36:55 PST 
Add logging of AXCoreObject outerHTML to AXLogger.
Comment 1 Andres Gonzalez 2020-11-15 09:43:47 PST 
Created attachment 414167 [details]
Patch
Comment 2 chris fleizach 2020-11-16 00:11:36 PST 
Comment on attachment 414167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414167&action=review

> Source/WebCore/accessibility/AXLogger.cpp:270
> +    const AXCoreObject* objectWithInterestingHtML = nullptr;

HtML > HTML

can we use auto here?
Comment 3 Andres Gonzalez 2020-11-16 06:40:35 PST 
Created attachment 414230 [details]
Patch
Comment 4 Andres Gonzalez 2020-11-16 06:42:19 PST 
(In reply to chris fleizach from comment #2)
> Comment on attachment 414167 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414167&action=review
> 
> > Source/WebCore/accessibility/AXLogger.cpp:270
> > +    const AXCoreObject* objectWithInterestingHtML = nullptr;
> 
> HtML > HTML

Fixed.
> 
> can we use auto here?

Done.
Comment 5 EWS 2020-11-16 10:12:38 PST 
Committed r269859: <https://trac.webkit.org/changeset/269859>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414230 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-16 10:13:17 PST 
<rdar://problem/71446493>