Bug 218956 – TextEncoderStreamEncoder should not be exposed

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[youenn fablet]

As spotted by Yusuke, TextEncoderStreamEncoder should not be exposed, ditto for TextDecoderStreamDecoder

[youenn fablet]

Created attachment 414162 [details]
Patch

[youenn fablet]

Created attachment 414168 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 414168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414168&action=review

r=me

> Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp:206
> +    if ((jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()->isSecureContext() && TestEnabledForContext::enabledForContext(*jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()))) {

Looks like we need to remove this brace.

> Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:248
> +    if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) {

Ditto about the brace.

> Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:251
> +    if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) {

Ditto.

> Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:717
> +    if (RuntimeEnabledFeatures::sharedFeatures().testFeatureEnabled()) {

Ditto.

[youenn fablet]

Created attachment 414197 [details]
Patch for landing

[EWS]

Committed r269847: <https://trac.webkit.org/changeset/269847>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414197 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71434621>