Bug 218950 - [LFC][Geometry] Add support for horizontal/vertical scrollbar spacing
Summary: [LFC][Geometry] Add support for horizontal/vertical scrollbar spacing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-14 20:06 PST by zalan
Modified: 2020-11-16 12:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.50 KB, patch)
2020-11-14 20:38 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-11-14 20:06:49 PST 
(this is for integration only)
Comment 1 zalan 2020-11-14 20:38:29 PST 
Created attachment 414153 [details]
Patch
Comment 2 EWS 2020-11-15 06:23:45 PST 
Committed r269825: <https://trac.webkit.org/changeset/269825>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414153 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-15 06:24:17 PST 
<rdar://problem/71414265>
Comment 4 Simon Fraser (smfr) 2020-11-16 08:25:52 PST 
Does this support the "scrollbars on the left" configuration?
Comment 5 zalan 2020-11-16 09:58:58 PST 
>Does this support the "scrollbars on the left" configuration?
Certainly not. This is about reserving space for the scrollbars which is pretty much all we need in the context of layout (unless I miss something here).
Comment 6 Simon Fraser (smfr) 2020-11-16 10:19:04 PST 
The left-side scrollbar does take space, so I think you'd have to support it. See shouldPlaceBlockDirectionScrollbarOnLeft()
Comment 7 zalan 2020-11-16 12:18:11 PST 
(In reply to Simon Fraser (smfr) from comment #6)
> The left-side scrollbar does take space, so I think you'd have to support
> it. See shouldPlaceBlockDirectionScrollbarOnLeft()
Let me rephrase it. This is an integration patch, so whatever the renderer has as scrollbar space, we reserve the same amount of pixels in BoxGeometry (when we copy the pre-computed geometry from RenderTree to LayoutTree). What I meant by "certainly not" was that at this point we don't really care whether it's a left or right scrollbar.