(this is for integration only)
Created attachment 414153 [details]
Committed r269825: <https://trac.webkit.org/changeset/269825>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 414153 [details].
Does this support the "scrollbars on the left" configuration?
>Does this support the "scrollbars on the left" configuration?
Certainly not. This is about reserving space for the scrollbars which is pretty much all we need in the context of layout (unless I miss something here).
The left-side scrollbar does take space, so I think you'd have to support it. See shouldPlaceBlockDirectionScrollbarOnLeft()
(In reply to Simon Fraser (smfr) from comment #6)
> The left-side scrollbar does take space, so I think you'd have to support
> it. See shouldPlaceBlockDirectionScrollbarOnLeft()
Let me rephrase it. This is an integration patch, so whatever the renderer has as scrollbar space, we reserve the same amount of pixels in BoxGeometry (when we copy the pre-computed geometry from RenderTree to LayoutTree). What I meant by "certainly not" was that at this point we don't really care whether it's a left or right scrollbar.