it flips the values based on the box's own writing mode and not the writing mode the box lives in. see https://www.w3.org/TR/css-writing-modes-4/#logical-direction-layout
Created attachment 414146 [details] Patch
Comment on attachment 414146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414146&action=review > Source/WebCore/ChangeLog:16 > + RenderStyle::marginStart/End/Before/After flips these values based on the box's own writing mode. Should these RenderStyle functions be renamed to make it more clear?
(In reply to Sam Weinig from comment #2) > Comment on attachment 414146 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414146&action=review > > > Source/WebCore/ChangeLog:16 > > + RenderStyle::marginStart/End/Before/After flips these values based on the box's own writing mode. > > Should these RenderStyle functions be renamed to make it more clear? Most certainly. I am not sure though what their name would be like. Guess I should figure out the cases where we would call them first.
Committed r269826: <https://trac.webkit.org/changeset/269826> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414146 [details].
<rdar://problem/71414284>