Bug 218935 - [webkitscmpy] Generalize parts of local.Scm class
Summary: [webkitscmpy] Generalize parts of local.Scm class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-13 21:01 PST by Jonathan Bedard
Modified: 2020-11-16 19:17 PST (History)
2 users (show)

See Also:


Attachments
Patch (13.77 KB, patch)
2020-11-13 21:05 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (13.80 KB, patch)
2020-11-16 17:10 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-11-13 21:01:33 PST
Some of the logic in the local.Scm class is also applicable for remote repositories. We should break those parts off into a more generic base class that local.Scm inherits from.
Comment 1 Radar WebKit Bug Importer 2020-11-13 21:02:24 PST
<rdar://problem/71395688>
Comment 2 Jonathan Bedard 2020-11-13 21:05:31 PST
Created attachment 414123 [details]
Patch
Comment 3 Aakash Jain 2020-11-16 15:47:59 PST
Comment on attachment 414123 [details]
Patch

rs=me
Comment 4 Jonathan Bedard 2020-11-16 17:10:03 PST
Created attachment 414295 [details]
Patch
Comment 5 EWS 2020-11-16 19:17:40 PST
Committed r269891: <https://trac.webkit.org/changeset/269891>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414295 [details].