Bug 218929 - WebAudio tests may give slightly different outputs on different platforms
Summary: WebAudio tests may give slightly different outputs on different platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-13 16:41 PST by Chris Dumez
Modified: 2020-11-16 08:42 PST (History)
9 users (show)

See Also:

Attachments
Patch (344.53 KB, patch)
2020-11-13 16:44 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (344.55 KB, patch)
2020-11-13 18:11 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-11-13 16:41:18 PST 
WebAudio tests may give slightly different outputs on different platforms, causing what looks like flakiness. This is due to the "(contains X different values)" because X may differ from one platform to another (usually +/- 1).
Comment 1 Chris Dumez 2020-11-13 16:44:22 PST 
Created attachment 414108 [details]
Patch
Comment 2 Sam Weinig 2020-11-13 17:06:32 PST 
Comment on attachment 414108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414108&action=review

Are you planning on submitting something to make a similar change upstream as well?

> LayoutTests/imported/w3c/ChangeLog:8
> +        webaudio_contains_different_values

This could use a better description.
Comment 3 Chris Dumez 2020-11-13 18:09:50 PST 
Comment on attachment 414108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414108&action=review

>> LayoutTests/imported/w3c/ChangeLog:8
>> +        webaudio_contains_different_values
> 
> This could use a better description.

Oops
Comment 4 Chris Dumez 2020-11-13 18:11:34 PST 
Created attachment 414113 [details]
Patch
Comment 5 Geoffrey Garen 2020-11-13 19:44:28 PST 
Comment on attachment 414113 [details]
Patch

r=me
Comment 6 EWS 2020-11-16 08:41:20 PST 
Committed r269853: <https://trac.webkit.org/changeset/269853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414113 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-16 08:42:24 PST 
<rdar://problem/71441476>