Bug 218921 – [GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

Error:

In file included from /home/matuschd/buildroot-4/build/wpewebkit-2.30.2/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-6.cpp:2:
/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp: In member function ‘void WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner(WebKit::WebPageGroupProxy*, const WTF::String&, bool)’:
/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:242:30: error: ‘class WebCore::Settings’ has no member named ‘setGenericCueAPIEnabled’; did you mean ‘setBeaconAPIEnabled’?
             page->settings().setGenericCueAPIEnabled(enabled);
                              ^~~~~~~~~~~~~~~~~~~~~~~
                              setBeaconAPIEnabled

[Adrian Perez]

Created attachment 414092 [details]
Patch

To be aplied in the webkit-2.30 branch

[Michael Catanzaro]

Comment on attachment 414092 [details]
Patch

Every EWS is red!

Once EWS is happy, just commit it. You don't need review for build fixes.

[Adrian Perez]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 414092 [details]
> Patch
> 
> Every EWS is red!
> 
> Once EWS is happy, just commit it. You don't need review for build fixes.

The code touched by this was removed in trunk, note that the patch is
for the webkit-2.30 branch, so of course the EWS builds *will* be red =]

[Adrian Perez]

Thanks for the review, Carlos! I have not manually landed this in
the webkit-2.30 branch 👍️