Bug 218921 - [GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF
Summary: [GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks: 218615
  Show dependency treegraph
 
Reported: 2020-11-13 13:47 PST by Adrian Perez
Modified: 2020-11-16 03:17 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2020-11-13 14:28 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-11-13 13:47:45 PST
Error:

In file included from /home/matuschd/buildroot-4/build/wpewebkit-2.30.2/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-6.cpp:2:
/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp: In member function ‘void WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner(WebKit::WebPageGroupProxy*, const WTF::String&, bool)’:
/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:242:30: error: ‘class WebCore::Settings’ has no member named ‘setGenericCueAPIEnabled’; did you mean ‘setBeaconAPIEnabled’?
             page->settings().setGenericCueAPIEnabled(enabled);
                              ^~~~~~~~~~~~~~~~~~~~~~~
                              setBeaconAPIEnabled
Comment 1 Adrian Perez 2020-11-13 14:28:33 PST
Created attachment 414092 [details]
Patch

To be aplied in the webkit-2.30 branch
Comment 2 Michael Catanzaro 2020-11-13 14:38:24 PST
Comment on attachment 414092 [details]
Patch

Every EWS is red!

Once EWS is happy, just commit it. You don't need review for build fixes.
Comment 3 Adrian Perez 2020-11-13 14:46:43 PST
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 414092 [details]
> Patch
> 
> Every EWS is red!
> 
> Once EWS is happy, just commit it. You don't need review for build fixes.

The code touched by this was removed in trunk, note that the patch is
for the webkit-2.30 branch, so of course the EWS builds *will* be red =]
Comment 4 Adrian Perez 2020-11-16 03:17:35 PST
Thanks for the review, Carlos! I have not manually landed this in
the webkit-2.30 branch 👍️